Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run multitag on coprocessor #816

Merged
merged 142 commits into from
Oct 17, 2023
Merged

Run multitag on coprocessor #816

merged 142 commits into from
Oct 17, 2023

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Feb 27, 2023

No description provided.

@amquake
Copy link
Member

amquake commented Oct 11, 2023

image

Seems to work, but to get the target outlines back Draw3dTargetsPipe would need to be modified to mimic the 2d version when a target has null tvec/rvec. (It is possible to have some targets with single-tag estimates and some without if doSingleTargetAlways is disabled and only some of the visible tags are in the tag layout)

@amquake
Copy link
Member

amquake commented Oct 14, 2023

but to get the target outlines back Draw3dTargetsPipe would need to be modified

Fixed this by computing the camera-to-tag transform for each tag that was used as part of the multitag result to replace the single-tag estimation.

@mcm001
Copy link
Contributor Author

mcm001 commented Oct 14, 2023

but to get the target outlines back Draw3dTargetsPipe would need to be modified

Fixed this by computing the camera-to-tag transform for each tag that was used as part of the multitag result to replace the single-tag estimation.

Aha, that's smart. Can we have a indicator of some form telling people that's what's happening? And maybe also hide the ambiguity column?

@amquake
Copy link
Member

amquake commented Oct 15, 2023

Can we have a indicator of some form telling people that's what's happening?

How's this?

2023-10-14.20-21-17_H.264.mp4

@mcm001 mcm001 merged commit 47bd077 into PhotonVision:master Oct 17, 2023
21 checks passed
@mcm001 mcm001 deleted the multiag-pnp branch October 17, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants